Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add ZplParameters Wrapper #21

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Conversation

itsmattking
Copy link
Collaborator

Makes a wrapper class to enforce usage of LinkedHashMap which will preserve key entry order. This is important as ZplBuilder expects all ZplCommand::parameters to be in the order added.

…eters`

To enforce use of `LinkedHashMap` on `ZplCommand`, add a simple wrapper class that uses `LinkedHashMap` underneath.
Copy link

@jbduncan jbduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Other than a couple of suggestions, I think this PR is ready to go. 👏

src/main/kotlin/com/sainsburys/k2zpl/command/ZplCommand.kt Outdated Show resolved Hide resolved
.idea/misc.xml Show resolved Hide resolved
Copy link

@jbduncan jbduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Squash-and-merge away. 😁

@itsmattking itsmattking merged commit 2dbb616 into main Sep 25, 2024
2 checks passed
@itsmattking itsmattking deleted the chore/create-zpl-parameters branch September 25, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants